Open
Conversation
- Modified Module Declaration so that modules can now be generated with empty parameter lists (when generators require no parameters). Added ASSERT statements to ensure that other exceptions are still caught. - Modified RemoveBulkConnections pass so that a BitInOut type is recognized as a Bit Type.
Modified the Makefile of CoreIR with a Debug flag, in order to allow debugging with GDB.
Modified `verilog` pass of CoreIR so that the default generator parameter values are propagated to the Verilog writer.
Removed all unnecessary comments.
JKHHai
changed the title
leonardt
requested changes
Sep 14, 2018
| prefix?=/usr/local | ||
| endif | ||
|
|
||
| COREDEBUG = True |
Collaborator
There was a problem hiding this comment.
I don't think should be checked in, seems like a debugging setting for yourself? FYI you can pass this as a flag to make, e.g. make COREDEBUG=1, rather than setting it in the file explicitly
|
|
||
| ifdef COREDEBUG | ||
| CXXFLAGS += -O0 -g3 -D_GLIBCXX_DEBUG | ||
| CXXFLAGS += -O0 -g3 |
Collaborator
There was a problem hiding this comment.
What's the reason for this removal?
leonardt
reviewed
Sep 14, 2018
| // return false; | ||
| // } | ||
| // } | ||
| // } |
Collaborator
There was a problem hiding this comment.
Can you submit the code in the comments as a separate PR? Or you could include it in this PR, but it would be good to include a test case that shows what this fixes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes changes to the CoreIR library.
Main changes:
RemoveBulkConnections: Fixed a bug where inouts were not recognized as bit connectionsaddDefaultGenArgs: Fixed a bug where the default parameters were not being propagated to the Verilog writer.Module: Made changes to Module constructor, so that Modules can be generated with emptygenargs, for greater flexibility.